Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Migrate from url/querystring modules to URL/URLSearchParams #15

Open
OliverJAsh opened this issue Dec 26, 2020 · 2 comments
Open

Migrate from url/querystring modules to URL/URLSearchParams #15

OliverJAsh opened this issue Dec 26, 2020 · 2 comments

Comments

@OliverJAsh
Copy link
Member

OliverJAsh commented Dec 26, 2020 •
edited
Loading

Related prior work: #7 #10

Fixing this will also fix #16 and #12
@OliverJAsh
Copy link
Member Author

OliverJAsh commented Dec 26, 2020 •
edited
Loading

Unlike url.parse, new URL(string) will throw if the value passed is not a valid URL. This makes me wonder whether we'll need to use Eithers or io-ts, now that validation would be involved. (#7)

This was referenced Dec 27, 2020
Open
Open
@samhh samhh mentioned this issue Apr 20, 2022
Open
@OliverJAsh
Copy link
Member Author

Also not clear how we will continue to support relative URLs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OliverJAsh