Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1072] Upgraded ENSCustody #301

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

nickshatilo
Copy link
Member

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@nickshatilo nickshatilo force-pushed the nickshatilo/REG-1072/upgrade-ens-custody branch from 99308cf to a0f487a Compare August 28, 2023 10:23
@nickshatilo nickshatilo changed the title [REG-1072] Upgraded ENSCustody on Goerli [REG-1072] Upgraded ENSCustody Aug 28, 2023
@nickshatilo nickshatilo requested review from aquiladev and a team August 28, 2023 10:23
@nickshatilo nickshatilo marked this pull request as ready for review August 28, 2023 10:23
@nickshatilo nickshatilo self-assigned this Aug 28, 2023
@nickshatilo nickshatilo force-pushed the nickshatilo/REG-1072/upgrade-ens-custody branch from a0f487a to 1298070 Compare August 29, 2023 14:13
@github-actions
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.055 0
MintingManager 13.614 0
ProxyReader 15.176 0
UNSRegistry 19.943 0

@nickshatilo nickshatilo merged commit 225b96d into main Aug 29, 2023
7 checks passed
@nickshatilo nickshatilo deleted the nickshatilo/REG-1072/upgrade-ens-custody branch August 29, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants