Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1449] feat: Update ENSCustody contract to support wallet migration #370

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

DancingAxolotl
Copy link
Contributor

@DancingAxolotl DancingAxolotl commented Oct 7, 2024

Related: #369

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@DancingAxolotl DancingAxolotl requested a review from a team October 7, 2024 19:28
DancingAxolotl and others added 3 commits October 7, 2024 20:32
@nickshatilo nickshatilo force-pushed the mike/REG-1449-update-enscustody-smart-contract branch from d63d52f to acb5930 Compare October 16, 2024 15:25
@nickshatilo nickshatilo force-pushed the mike/REG-1449-update-enscustody-smart-contract branch from acb5930 to 2ac8454 Compare October 16, 2024 15:41
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 14.048 +0.984
MintingManager 18.92 0
ProxyReader 15.176 0
UNSRegistry 20.725 0

@nickshatilo nickshatilo merged commit ad7a194 into main Oct 17, 2024
8 checks passed
@nickshatilo nickshatilo deleted the mike/REG-1449-update-enscustody-smart-contract branch October 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants