Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derive_lang_from_path to derive from any part of path #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

george-gca
Copy link
Contributor

@george-gca george-gca commented Nov 14, 2024

🔤 Polyglot PR

Currently derive_lang_from_path only considers small parts of the path. This changes to consider any part in any/part/of/the/path.txt. This allows, for example, creating files like assets/data/en-us/cards.json and assets/data/pt-br/cards.json and setting its permalink to /assets/data/cards.json.

I need help setting tests for this, I have no idea where to start.

typing as crazy

Type of change

  • Docs update (changes to the readme or a site page, no code changes)
  • Ops wrangling (automation or test improvements)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Sweet release (needs a lot of work and effort)
  • Something else (explain please)

Checklists

  • If modifying code, at least one test has been added to the suite

@george-gca
Copy link
Contributor Author

Now just missing the testing part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants