Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

359 feature exception handling #368

Open
wants to merge 10 commits into
base: main-dev
Choose a base branch
from

Conversation

VioletaStepanyan
Copy link
Contributor

Exception handling

Copy link
Contributor

@ashvardanian ashvardanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks bad. Changing indent in every line just to fit try-catch blocks isn’t a solutions.

@@ -194,43 +194,47 @@ void ustore_snapshot_list(ustore_snapshot_list_t* c_ptr) {
return_error_if_m(c.db, c.error, uninitialized_state_k, "DataBase is uninitialized");
return_error_if_m(c.count && c.ids, c.error, args_combo_k, "Need outputs!");

linked_memory_lock_t arena = linked_memory(c.arena, c.options, c.error);
return_if_error_m(c.error);
safe_section("Geting Snapshot List", c.error, [&] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling.

@@ -244,51 +244,56 @@ void ustore_snapshot_list(ustore_snapshot_list_t* c_ptr) {
return_error_if_m(c.db, c.error, uninitialized_state_k, "DataBase is uninitialized");
return_error_if_m(c.count && c.ids, c.error, args_combo_k, "Need outputs!");

linked_memory_lock_t arena = linked_memory(c.arena, c.options, c.error);
return_if_error_m(c.error);
safe_section("Geting Snapshot List", c.error, [&] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants