create recovery timer mechanism #273
clippy
88 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 88 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check warning on line 167 in boards/sensor/src/main.rs
github-actions / clippy
empty `loop {}` wastes CPU cycles
warning: empty `loop {}` wastes CPU cycles
--> boards/sensor/src/main.rs:167:9
|
167 | loop {}
| ^^^^^^^
|
= help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
= note: `#[warn(clippy::empty_loop)]` on by default
Check warning on line 134 in boards/sensor/src/sbg_manager.rs
github-actions / clippy
using `clone` on type `[u8; 1024]` which implements the `Copy` trait
warning: using `clone` on type `[u8; 1024]` which implements the `Copy` trait
--> boards/sensor/src/sbg_manager.rs:134:33
|
134 | let buf_clone = buf.clone();
| ^^^^^^^^^^^ help: try dereferencing it: `*buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 73 in boards/sensor/src/communication.rs
github-actions / clippy
this function has too many arguments (8/7)
warning: this function has too many arguments (8/7)
--> boards/sensor/src/communication.rs:64:5
|
64 | / pub fn new<S>(
65 | | can_rx: Pin<PA23, AlternateI>,
66 | | can_tx: Pin<PA22, AlternateI>,
67 | | pclk_can: Pclk<Can0, Gclk0Id>,
... |
72 | | loopback: bool,
73 | | ) -> (Self, S::Inc)
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 59 in boards/sensor/src/communication.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> boards/sensor/src/communication.rs:54:14
|
54 | pub can: Can<
| ______________^
55 | | 'static,
56 | | Can0,
57 | | Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>,
58 | | Capacities,
59 | | >,
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 486 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
you seem to be trying to use `match` for an equality check. Consider using `if`
warning: you seem to be trying to use `match` for an equality check. Consider using `if`
--> libraries/sbg-rs/src/sbg.rs:479:5
|
479 | / match logType {
480 | | // silently handle errors
481 | | // _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_ERROR => error!("SBG Error"),
482 | | _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING => warn!("SBG Warning"),
... |
485 | | _ => (),
486 | | };
| |_____^ help: try: `if logType == _SbgDebugLogType_SBG_DEBUG_LOG_TYPE_WARNING { warn!("SBG Warning") }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
Check warning on line 467 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unsafe function's docs miss `# Safety` section
warning: unsafe function's docs miss `# Safety` section
--> libraries/sbg-rs/src/sbg.rs:459:1
|
459 | / pub unsafe extern "C" fn sbgPlatformDebugLogMsg(
460 | | _pFileName: *const ::core::ffi::c_char,
461 | | _pFunctionName: *const ::core::ffi::c_char,
462 | | _line: u32,
... |
466 | | _pFormat: *const ::core::ffi::c_char,
467 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
Check warning on line 421 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> libraries/sbg-rs/src/sbg.rs:421:23
|
421 | Err(_) => return _SbgErrorCode_SBG_READ_ERROR,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
421 | Err(_) => _SbgErrorCode_SBG_READ_ERROR,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 420 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> libraries/sbg-rs/src/sbg.rs:420:22
|
420 | Ok(_) => return _SbgErrorCode_SBG_NO_ERROR,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
420 | Ok(_) => _SbgErrorCode_SBG_NO_ERROR,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 409 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unsafe function's docs miss `# Safety` section
warning: unsafe function's docs miss `# Safety` section
--> libraries/sbg-rs/src/sbg.rs:406:5
|
406 | / pub unsafe extern "C" fn SbgFlushFunc(
407 | | pInterface: *mut _SbgInterface,
408 | | _flags: u32,
409 | | ) -> _SbgErrorCode {
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
Check warning on line 360 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unsafe function's docs miss `# Safety` section
warning: unsafe function's docs miss `# Safety` section
--> libraries/sbg-rs/src/sbg.rs:354:5
|
354 | / pub unsafe extern "C" fn SbgEComReceiveLogFunc(
355 | | _pHandle: *mut _SbgEComHandle,
356 | | msgClass: u32,
357 | | msg: u32,
358 | | pLogData: *const _SbgBinaryLogData,
359 | | _pUserArg: *mut c_void,
360 | | ) -> _SbgErrorCode {
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
Check warning on line 319 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unsafe function's docs miss `# Safety` section
warning: unsafe function's docs miss `# Safety` section
--> libraries/sbg-rs/src/sbg.rs:315:5
|
315 | / pub unsafe extern "C" fn SbgInterfaceWriteFunc(
316 | | pInterface: *mut _SbgInterface,
317 | | pBuffer: *const c_void,
318 | | bytesToWrite: usize,
319 | | ) -> _SbgErrorCode {
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
Check warning on line 298 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
the loop variable `i` is only used to index `array`
warning: the loop variable `i` is only used to index `array`
--> libraries/sbg-rs/src/sbg.rs:298:18
|
298 | for i in 0..(bytesToRead) {
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
298 | for <item> in array.iter_mut().take((bytesToRead)) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 309 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> libraries/sbg-rs/src/sbg.rs:309:9
|
309 | return _SbgErrorCode_SBG_NO_ERROR;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
309 - return _SbgErrorCode_SBG_NO_ERROR;
309 + _SbgErrorCode_SBG_NO_ERROR
|
Check warning on line 286 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
unsafe function's docs miss `# Safety` section
warning: unsafe function's docs miss `# Safety` section
--> libraries/sbg-rs/src/sbg.rs:281:5
|
281 | / pub unsafe extern "C" fn SbgInterfaceReadFunc(
282 | | _pInterface: *mut _SbgInterface,
283 | | pBuffer: *mut c_void,
284 | | pBytesRead: *mut usize,
285 | | bytesToRead: usize,
286 | | ) -> _SbgErrorCode {
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `#[warn(clippy::missing_safety_doc)]` on by default
Check warning on line 498 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
creating a shared reference to mutable static is discouraged
warning: creating a shared reference to mutable static is discouraged
--> libraries/sbg-rs/src/sbg.rs:498:15
|
498 | match &RTC {
| ^^^^ shared reference to mutable static
|
= note: for more information, see issue #114447 <https://github.com/rust-lang/rust/issues/114447>
= note: this will be a hard error in the 2024 edition
= note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior
= note: `#[warn(static_mut_refs)]` on by default
help: use `addr_of!` instead to create a raw pointer
|
498 | match addr_of!(RTC) {
| ~~~~~~~~~~~~~
Check warning on line 140 in libraries/sbg-rs/src/sbg.rs
github-actions / clippy
redundant field names in struct initialization
warning: redundant field names in struct initialization
--> libraries/sbg-rs/src/sbg.rs:140:13
|
140 | handle: handle,
| ^^^^^^^^^^^^^^ help: replace it with: `handle`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
Check warning on line 13476 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint`
warning: unused import: `self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint`
--> libraries/sbg-rs/src/bindings.rs:13476:9
|
13476 | pub use self::_SbgEComOutputMonitoringPoint as SbgEComOutputMonitoringPoint;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 10537 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus`
warning: unused import: `self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus`
--> libraries/sbg-rs/src/bindings.rs:10537:9
|
10537 | pub use self::_SbgEComClockUtcStatus as SbgEComClockUtcStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 10527 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComClockStatus as SbgEComClockStatus`
warning: unused import: `self::_SbgEComClockStatus as SbgEComClockStatus`
--> libraries/sbg-rs/src/bindings.rs:10527:9
|
10527 | pub use self::_SbgEComClockStatus as SbgEComClockStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 10251 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComCanBusStatus as SbgEComCanBusStatus`
warning: unused import: `self::_SbgEComCanBusStatus as SbgEComCanBusStatus`
--> libraries/sbg-rs/src/bindings.rs:10251:9
|
10251 | pub use self::_SbgEComCanBusStatus as SbgEComCanBusStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 8535 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus`
warning: unused import: `self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus`
--> libraries/sbg-rs/src/bindings.rs:8535:9
|
8535 | pub use self::_SbgEComGpsHdtStatus as SbgEComGpsHdtStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 8523 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComGpsPosType as SbgEComGpsPosType`
warning: unused import: `self::_SbgEComGpsPosType as SbgEComGpsPosType`
--> libraries/sbg-rs/src/bindings.rs:8523:9
|
8523 | pub use self::_SbgEComGpsPosType as SbgEComGpsPosType;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 8497 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus`
warning: unused import: `self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus`
--> libraries/sbg-rs/src/bindings.rs:8497:9
|
8497 | pub use self::_SbgEComGpsPosStatus as SbgEComGpsPosStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 8485 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComGpsVelType as SbgEComGpsVelType`
warning: unused import: `self::_SbgEComGpsVelType as SbgEComGpsVelType`
--> libraries/sbg-rs/src/bindings.rs:8485:9
|
8485 | pub use self::_SbgEComGpsVelType as SbgEComGpsVelType;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 8473 in libraries/sbg-rs/src/bindings.rs
github-actions / clippy
unused import: `self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus`
warning: unused import: `self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus`
--> libraries/sbg-rs/src/bindings.rs:8473:9
|
8473 | pub use self::_SbgEComGpsVelStatus as SbgEComGpsVelStatus;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^