Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ULIB-33] timer 훅 분리 및 수정 #33

Merged
merged 5 commits into from
Sep 19, 2023
Merged

[ULIB-33] timer 훅 분리 및 수정 #33

merged 5 commits into from
Sep 19, 2023

Conversation

eunbae0
Copy link
Member

@eunbae0 eunbae0 commented Sep 18, 2023

Summary

  • Timer 컴포넌트에서 timer 상태를 외부에서 주입하는 방식으로 사용하기 위해 Timer 컴포넌트 내부의 useTimer훅을 제거하였습니다.
  • useTimer에 받는 인자를 object로 변경하였습니다.
  • autoStart 옵션을 추가하였습니다. 기본으로 true를 받습니다.
  • 0를 추가하여 string으로 반환하는 addZero함수를 훅 외부로 분리하였습니다.

@eunbae0 eunbae0 self-assigned this Sep 18, 2023
@commit-lint
Copy link

commit-lint bot commented Sep 18, 2023

Features

  • useTimer 훅 제거 (6408e8d)
  • input story에 currentTime 추가 (a765c6c)
  • autoStart 옵션 추가 (3c62316)

Contributors

eunbae0

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@eunbae0 eunbae0 changed the title [ULIB-33] timer 훅 분리 [ULIB-33] timer 훅 분리 및 수정 Sep 19, 2023
@eunbae0 eunbae0 merged commit c62c1a8 into main Sep 19, 2023
@eunbae0 eunbae0 deleted the ULIB-33 branch January 24, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant