feat(spaces-artifacts): add option to push in parallel image to spacess-artifacts #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-artifacts Signed-off-by: Christopher Haar <[email protected]>
|
@turkenh think we need to backport this in the other active release branches too - wdyt ? |
turkenh
reviewed
Sep 11, 2024
| @@ -51,7 +51,7 @@ KIND_VERSION = v0.21.0 | |||
| # Due to the way that the shared build logic works, images should | |||
| # all be in folders at the same level (no additional levels of nesting). | |||
|
|
|||
| REGISTRY_ORGS ?= docker.io/upbound xpkg.upbound.io/upbound | |||
| REGISTRY_ORGS ?= docker.io/upbound xpkg.upbound.io/upbound xpkg.upbound.io/spaces-artifacts | |||
There was a problem hiding this comment.
Hmm, I think we will need to translate this to earthly way 🤔 Let me check what it means.
There was a problem hiding this comment.
same for upbound/universal-crossplane - or what we want todo here ? - i will wait to open the PR then
There was a problem hiding this comment.
No, I think we should stick to the build submodule there.
turkenh
approved these changes
Sep 12, 2024
|
Git push to origin failed for release-1.15 with exitcode 1 |
|
Git push to origin failed for release-1.16 with exitcode 1 |
turkenh
added a commit
to turkenh/upbound-crossplane
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Hasan Turken <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
push images to xpkg.upbound.io/spaces-artifacts in parallel
we need to add the new ENV Variables:
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.