Skip to content

Fixed showing message and 'upload-success' event after server response #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed showing message and 'upload-success' event after server response #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
> A drag and drop multiple file uploader component that uses Vue.js v2 and Axios. Uploader shows file names, sizes and total size of files added. It also allows
setting a minimum required number of files to upload.

### About this fork by Chupzzz

Original component by *updivision* worked fine except of *successMessagePath/errorMessagePath* props and *upload-success* event - all of them wasn't working properly. So this fork has this issues fixed. Pull request to updivision has been sent.

### Demo
See live demo [here](https://updivision.github.io/vue2-multi-uploader/).

Expand Down
5 changes: 3 additions & 2 deletions src/MultipleFileUploader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,14 @@ export default {
this.isLoaderVisible = false;
// Show success message
if(this.showHttpMessages)
this.successMsg = response + "." + this.successMessagePath;
this.successMsg = response.data[this.successMessagePath];
this.removeItems();
this.$emit('upload-success', response);
})
.catch((error) => {
this.isLoaderVisible = false;
if(this.showHttpMessages)
this.errorMsg = error + "." + this.errorMessagePath;
this.errorMsg = error.data[this.errorMessagePath];
this.removeItems();
});
} else {
Expand Down