Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments releated to previous pull-request review #7

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Address comments releated to previous pull-request review #7

merged 1 commit into from
Oct 27, 2023

Conversation

satazor
Copy link
Contributor

@satazor satazor commented Oct 27, 2023

See #2

@satazor satazor force-pushed the enhancement/post-review-address branch from a86e41d to e522eca Compare October 27, 2023 17:54
@satazor satazor force-pushed the enhancement/post-review-address branch from e522eca to 7e7966b Compare October 27, 2023 17:57
jspranger
jspranger approved these changes Oct 27, 2023
View reviewed changes
Copy link

@jspranger jspranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jspranger jspranger merged commit 8941227 into master Oct 27, 2023
2 checks passed
@jspranger jspranger deleted the enhancement/post-review-address branch October 27, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspranger jspranger jspranger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satazor @jspranger