Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable parameters to changelog #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nunofgs
Copy link

@nunofgs nunofgs commented Sep 29, 2020

Allows calling uphold-scripts changelog and manually specify the tag and release name.

Note that the argument parsing isn't perfect (neither was the original script). There's multiple ways to escape it but I feel that it's good enough for our usual use cases.

@rplopes
Copy link
Contributor

rplopes commented Sep 30, 2020

The format -future-release <version> -future-release-tag v<version> was chosen because at that time, it seemed to be the convention for changelogs on our projects. Now, it seems to be -future-release v<version> -future-release-tag v<version>, which can be simplified to -future-release v<version>.

WDYT about changing the behaviour to start outputting in that format? It would probably simplify many projects' setups, without any flag. It would be a breaking change in this library, but as long as we follow semver, it looks like a pretty reasonable one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants