Skip to content

Commit

Permalink
Switch eslint-plugin-jsx-expressions to @eslint-react (#424)
Browse files Browse the repository at this point in the history
  • Loading branch information
karlhorky authored Sep 9, 2024
1 parent 2603313 commit 2fa534a
Show file tree
Hide file tree
Showing 17 changed files with 223 additions and 249 deletions.
2 changes: 0 additions & 2 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ const config = [
ignores: [
// Tests
'__tests__/**/*',
// Vendored packages (workarounds for incompatibilities)
'vendor/**/*',
],
},
];
Expand Down
14 changes: 7 additions & 7 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import eslintImportX from 'eslint-plugin-import-x';
import jsxA11y from 'eslint-plugin-jsx-a11y';
import react from 'eslint-plugin-react';
import reactHooks from 'eslint-plugin-react-hooks';
import * as reactX from 'eslint-plugin-react-x';
import security from 'eslint-plugin-security';
import sonarjs from 'eslint-plugin-sonarjs';
import unicorn from 'eslint-plugin-unicorn';
import upleveled from 'eslint-plugin-upleveled';
import globals from 'globals';
import isPlainObject from 'is-plain-obj';
import stripJsonComments from 'strip-json-comments';
import jsxExpressions from './vendor/eslint-plugin-jsx-expressions/dist/index.js';

/** @type
* {import('@typescript-eslint/utils/ts-eslint').FlatConfig.RuleLevelAndOptions}
Expand Down Expand Up @@ -512,8 +512,9 @@ const configArray = [
'@typescript-eslint': {
rules: eslintTypescript.rules,
},
'import-x': eslintImportX,
'jsx-a11y': jsxA11y,
'jsx-expressions': jsxExpressions,
'react-x': reactX,
'react-hooks':
// Fix eslint-plugin-react-hooks for ESLint 9
//
Expand All @@ -526,7 +527,6 @@ const configArray = [
reactHooks
),
),
'import-x': eslintImportX,
react: fixupPluginRules(react),
security,
sonarjs: {
Expand Down Expand Up @@ -847,10 +847,6 @@ const configArray = [
// Disable obsolete rule
// https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/398#issuecomment-728976688
'jsx-a11y/no-onchange': 'off',
// Disallow potentially falsey string and number values in
// logical && expressions
// https://github.com/hpersson/eslint-plugin-jsx-expressions/blob/master/docs/rules/strict-logical-expressions.md
'jsx-expressions/strict-logical-expressions': 'error',
// Warn on async promise executor function
// https://github.com/eslint/eslint/blob/main/docs/src/rules/no-async-promise-executor.md
'no-async-promise-executor': 'warn',
Expand Down Expand Up @@ -930,6 +926,10 @@ const configArray = [
// Error on passing children to void elements
// https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/void-dom-elements-no-children.md
'react/void-dom-elements-no-children': 'error',
// Disallow potentially falsey string and number values in
// logical && expressions
// https://eslint-react.xyz/docs/rules/no-leaked-conditional-rendering
'react-x/no-leaked-conditional-rendering': 'error',
// Error on trojan source code attacks using bidirectional
// characters
// https://github.com/eslint-community/eslint-plugin-security/blob/main/docs/rules/detect-bidi-characters.md
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"files": [
"bin",
"templates",
"vendor",
"index.js",
"index.d.ts",
"tsconfig.base.json"
Expand All @@ -46,6 +45,7 @@
"eslint-plugin-import-x": "4.2.1",
"eslint-plugin-jsx-a11y": "6.10.0",
"eslint-plugin-react": "7.35.2",
"eslint-plugin-react-x": "1.13.1",
"eslint-plugin-react-hooks": "4.6.2",
"eslint-plugin-security": "3.0.1",
"eslint-plugin-sonarjs": "1.0.4",
Expand Down
Loading

0 comments on commit 2fa534a

Please sign in to comment.