DX-960: Update Deny List from SDK #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in ip deny lists, we use an open source IP deny list aggregator as a source for blocking IP addresses automatically. We keep a status flag at redis to denote the state. When the feature is disabled, flag is set to disabled with no expiry date. Otherwise, it's either set to a value with some expiry or expired. We use these three states to define what we do: - disabled with no ttl: don't do anything. use list of all deny lists it as it is (with values entered by the user) - set with some ttl: don't do anything. use list of all deny lists it as it is (which includes user values and the ip list) - deleted: this means the ip list must be updated. The result is returned to the user and an async is process is attached to the pending field in our response Mind that the first two states are the same, but we differentiate them to explain what's going on.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ogzhanolguncu
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only planning to update the open source deny list from the console.
Now, we will do it in the sdk aswell. After updating the IP list, the list will be valid until 2 AM UTC which is a bit later than the usual update time of our data source. When the list becomes invalid, the first request sent with the sdk will update the ip list asynchronously.