DX-1264: Unify exports #1290
Merged
DX-1264: Unify exports #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are not passing @ytkimirti |
CahidArda
previously approved these changes
Oct 4, 2024
We can remove these two because the files they were referencing did not exist in the older versions. So this is not a breaking change
CahidArda
approved these changes
Oct 4, 2024
CahidArda
approved these changes
Oct 4, 2024
fahreddinozcan
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some small tweaks to unify some parts of our javascript packages. Here are the changes:
node.jsandnode.mjsexports are removed since they did not resolve to a file and do not work in the prod version.cloudflare.js,cloudflare.mjs,fastly.jsandfastly.mjsexports are kept for backwards compatibility.