Remove sleep after the last retry attempt

.github/workflows/tests.yaml

@@ -222,7 +222,7 @@ jobs:
         run: sed -i 's;@upstash/redis@latest;@upstash/redis@${{needs.release.outputs.version}};' ./examples/deno/main.ts
 
       - name: Deploy
-        run: deno run -A https://deno.land/x/deploy/deployctl.ts deploy --project=upstash-redis ./main.ts
+        run: deno run -A https://deno.land/x/deploy@1.12.0/deployctl.ts deploy --project=upstash-redis ./main.ts
         working-directory: examples/deno
         env:
           DENO_DEPLOY_TOKEN: ${{ secrets.DENO_DEPLOY_TOKEN }}

examples/deno/main.ts

@@ -1,4 +1,4 @@
-import { serve } from "https://deno.land/std@0.177.0/http/server.ts";
+import { serve } from "https://deno.land/std@0.224.0/http/server.ts";
 import { Redis } from "https://esm.sh/@upstash/redis@latest";
 
 serve(async (_req: Request) => {

pkg/http.test.ts

@@ -0,0 +1,23 @@
+import { describe, test, expect } from "bun:test";
+import { Redis } from "../platforms/nodejs";
+
+describe("http", () => {
+  test("should terminate after sleeping 5 times", async () => {
+    // init a cient which will always get errors
+    const redis = new Redis({
+      url: undefined,
+      token: "non-existent",
+      // set retry explicitly
+      retry: {
+        retries: 5,
+        backoff: (retryCount) => Math.exp(retryCount) * 50,
+      },
+    });
+
+    // get should take 4.287 seconds and terminate before the timeout.
+    const throws = () => Promise.race([redis.get("foo"), new Promise((r) => setTimeout(r, 4500))]);
+
+    // if the Promise.race doesn't throw, that means the retries took longer than 4.5s
+    expect(throws).toThrow("fetch() URL is invalid");
+  });
+});

pkg/http.ts

@@ -243,7 +243,11 @@ export class HttpClient implements Requester {
           break;
         }
         error = error_ as Error;
-        await new Promise((r) => setTimeout(r, this.retry.backoff(i)));
+
+        // Only sleep if this is not the last attempt
+        if (i < this.retry.attempts) {
+          await new Promise((r) => setTimeout(r, this.retry.backoff(i)));
+        }
       }
     }
     if (!res) {