-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Python package, drop Elasticsearch 1.0.3 support, get CI working again #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
changed the title
remove Python package
remove Python package, drop Elasticsearch 1.0.3 support
Jan 11, 2025
jameslamb
changed the title
remove Python package, drop Elasticsearch 1.0.3 support
remove Python package, drop Elasticsearch 1.0.3 support, get CI working again
Jan 11, 2025
yay CI works again 🎉 All things considered... pretty cool that this is all it took after around 4 years of inactivity. |
This was referenced Jan 11, 2025
This was referenced Jan 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Python package.
Based on offline conversations with @austin3dickey and @ngparas , we've decided to retire the Python package here and focus this repo only on the R package (https://cran.r-project.org/web/packages/uptasticsearch/index.html).
The Python package was never distributed via package managers and I don't think it's in use anywhere today.
Notes for Reviewers
Other changes to get CI working
Updating syntax for
{lintr}
To fix stuff like this:
Skipping
{lintr}
checks that raise errors (I'll fix these in follow-up PRs).*Dropping Elasticsearch 1.0.3 support
The Docker images we were using for that support can't run on newer versions of docker.
(build link)
Seems ok... Elasticsearch 1.0.3 came out in April 2014 (link).