Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'covr' from Suggests, remove unused importFrom #235

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jameslamb
Copy link
Collaborator

Some cleanup of dependencies.

  • removes {covr} from Suggests:
    • {covr} is only used in CI scripts here, not for anything CRAN sees
    • removing it from Suggests makes reverse dependency checking a little cheaper for CRAN and for {covr} maintainers... and avoids the need to install {covr} to check {uptasticsearch}
  • removes import of stringr::str_detect()
  • re-renders the docs with {roxygen2} 7.3.2 (the latest version)

@jameslamb jameslamb added the maintenance miscellaneous maintenance label Jan 29, 2025
@jameslamb jameslamb changed the title WIP: remove 'covr' from Suggests, remove unused importFrom remove 'covr' from Suggests, remove unused importFrom Jan 29, 2025
@jameslamb jameslamb marked this pull request as ready for review January 29, 2025 05:16
@jameslamb jameslamb merged commit d45fa31 into uptake:main Jan 29, 2025
18 checks passed
@jameslamb jameslamb deleted the indentation branch January 29, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance miscellaneous maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant