Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary root rotation on metadata expiry #115

Merged
merged 6 commits into from
Aug 13, 2024

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    625c541 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Reproducer for TOR-3452

    cajun-rat committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a674dd0 View commit details
    Browse the repository at this point in the history
  2. Fix for TOR-3452

    The problem was that the first call to checkMetaOffline() throws an exception
    which results in image_repo_->checkMetaOffline() not being called.
    
    There are a bunch of root causes that should be fixed at some point:
     - The *Repository classes are not fully initialized in the ctor
     - The required initialization is called 'checkMetaOffline()''
     - There is no documentation that says this is so
     - There are no asserts to enforce the above requirement at runtime.
    cajun-rat committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    d4f91ff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac7a761 View commit details
    Browse the repository at this point in the history
  4. Remove default ctor for Uptane::Root

    There only one place that uses this default, so remove the default ctor and
    explicitly express it in RepositoryCommon. This means that no-one has to
    remember "What is the policy for a default-constructed Root object?"" any more.
    cajun-rat committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    f476f21 View commit details
    Browse the repository at this point in the history
  5. Tidy up root rotation logic

    This wasn't implicated in TOR-3452, but the new version is shorter and has
    simple control flow.
    cajun-rat committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    bda0573 View commit details
    Browse the repository at this point in the history