-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor garagesign task and fetch its binary from a new location #107
Merged
ricardosalveti
merged 3 commits into
uptane:scarthgap
from
EdTheBearded:uptane-sign-scarth
Aug 15, 2024
Merged
Refactor garagesign task and fetch its binary from a new location #107
ricardosalveti
merged 3 commits into
uptane:scarthgap
from
EdTheBearded:uptane-sign-scarth
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f88fb5fae (HEAD -> master, origin/master, origin/HEAD) Merge pull request uptane#112 from uptane/fix/garage-cli cf48737d1 Fetch garage-sign from a new location 3662ed09e Merge pull request uptane#108 from cajun-rat/correlation-id 45047239d Add default to load installed version with correlation id 146d347d8 Move CorrelationID up a level out of Target dad1cbe27 Merge pull request uptane#109 from cajun-rat/various-tidy cdc604ba1 Merge pull request uptane#110 from uptane/header-fix 13e9eb4f0 Merge pull request uptane#111 from uptane/docs/contributing febb95cce Docs: Update CONTRIBUTING to reflect new policies c0bf7314f Add missing include cc33025e1 Various tidy-ups 513aadfaf Merge pull request uptane#107 from cajun-rat/more-flow-control 91ead679b Introduce finer-grained cancellation of operations Signed-off-by: Jose Manuel Diez <[email protected]> (cherry picked from commit 2a83537) Signed-off-by: Eduardo Ferreira <[email protected]>
See uptane/aktualizr#112. Signed-off-by: Jose Manuel Diez <[email protected]> (cherry picked from commit b1d7636) Signed-off-by: Eduardo Ferreira <[email protected]>
To enable usage of the Uptane's 'ota-tuf' repository for uptane-sign, we need to change this task. Since in more recent releases there, the tool name has changed from 'garage-sign' to 'uptane-sign'. This way, we set the name of the tool used in a customizable variable, defaulting to 'garage-sign', and if anyone wants to use the latest version of this tool (given Aktualizr was also refactored), they just need to set this new variable with the tool name. Signed-off-by: Eduardo Ferreira <[email protected]> (cherry picked from commit 397c3ab) Signed-off-by: Eduardo Ferreira <[email protected]>
ricardosalveti
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ricardosalveti
pushed a commit
that referenced
this pull request
Aug 15, 2024
f88fb5fae (HEAD -> master, origin/master, origin/HEAD) Merge pull request #112 from uptane/fix/garage-cli cf48737d1 Fetch garage-sign from a new location 3662ed09e Merge pull request #108 from cajun-rat/correlation-id 45047239d Add default to load installed version with correlation id 146d347d8 Move CorrelationID up a level out of Target dad1cbe27 Merge pull request #109 from cajun-rat/various-tidy cdc604ba1 Merge pull request #110 from uptane/header-fix 13e9eb4f0 Merge pull request #111 from uptane/docs/contributing febb95cce Docs: Update CONTRIBUTING to reflect new policies c0bf7314f Add missing include cc33025e1 Various tidy-ups 513aadfaf Merge pull request #107 from cajun-rat/more-flow-control 91ead679b Introduce finer-grained cancellation of operations Signed-off-by: Jose Manuel Diez <[email protected]> (cherry picked from commit 2a83537) Signed-off-by: Eduardo Ferreira <[email protected]>
EdTheBearded
pushed a commit
to EdTheBearded/meta-updater
that referenced
this pull request
Oct 30, 2024
f88fb5fae (HEAD -> master, origin/master, origin/HEAD) Merge pull request uptane#112 from uptane/fix/garage-cli cf48737d1 Fetch garage-sign from a new location 3662ed09e Merge pull request uptane#108 from cajun-rat/correlation-id 45047239d Add default to load installed version with correlation id 146d347d8 Move CorrelationID up a level out of Target dad1cbe27 Merge pull request uptane#109 from cajun-rat/various-tidy cdc604ba1 Merge pull request uptane#110 from uptane/header-fix 13e9eb4f0 Merge pull request uptane#111 from uptane/docs/contributing febb95cce Docs: Update CONTRIBUTING to reflect new policies c0bf7314f Add missing include cc33025e1 Various tidy-ups 513aadfaf Merge pull request uptane#107 from cajun-rat/more-flow-control 91ead679b Introduce finer-grained cancellation of operations Signed-off-by: Jose Manuel Diez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking to Scarthgap the commits made to master on 2 different PR:
#104
#105