Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit-conf: fix u-boot boot fail #77

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

pagousmile
Copy link

On board using a fitImage, poky's upstream change from the following commit:
https://git.yoctoproject.org/poky/commit/?id=ab6b5e97cebe19938baa403da6307ca320294b3a
inserted a regression of the fit-conf.bb recipe.
Causing a U-boot boot fault displaying this type of message:

  Could not find configuration node
  ERROR: can't get kernel image!
  Unknown command '!' - try 'help'
  resetting ...

fitImage configuration labels are now prefixed with conf- instead of conf@.
This commit incorporates this modification for the fit-conf.bb recipe.

fix #75

On board using a fitImage, poky's upstream change from the following
commit:
https://git.yoctoproject.org/poky/commit/?id=ab6b5e97cebe19938baa403da63
07ca320294b3a
inserted a regression of the fit-conf.bb recipe.
Causing a U-boot boot fault displaying this type of message:
```
  Could not find configuration node
  ERROR: can't get kernel image!
  Unknown command '!' - try 'help'
  resetting ...
```
fitImage configuration labels are now prefixed with conf- instead of
conf@.
This commit incorporates this modification for the fit-conf.bb recipe.
@pagousmile pagousmile force-pushed the fix-u-boot-boot-fail branch from d6e02f9 to c3fb15c Compare June 2, 2023 07:20
Copy link
Collaborator

@pattivacek pattivacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I don't have proper means to test this, so I sorta have to trust you, but it makes sense to me.

@pattivacek pattivacek merged commit 30215cc into uptane:kirkstone Jun 21, 2023
@tcikel tcikel mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants