Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Exposing component methods (forwardRef) #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tmarcinkowski-logitech
Copy link
Contributor

@tmarcinkowski-logitech tmarcinkowski-logitech commented Jun 17, 2021

Description

According to React documentation, this is a breaking change. Unfortunately, this is the only way to use methods like toggleFolder or manipulate a component's state from the outside.

Changelog

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I actively use this change in my codebase

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dreadera dreadera added enhancement breaking Breaking Changes labels Jun 17, 2021
@tmarcinkowski-logitech tmarcinkowski-logitech changed the title Exposing component methods (forwardRef) feature: Exposing component methods (forwardRef) Jun 21, 2021
@derekzernach
Copy link

Would love to see this added, in previous versions I was able to open folders when the file browser loaded and I can't seem to do this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants