Add RelationWithOpts to SelectQuery for Customizing JOIN ON Clause #1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #554.
This PR introduces a new method, RelationWithOpts, to the SelectQuery interface. This method allows users to customize the JOIN ON clause when defining relationships between models (e.g., has-one, has-many).
Key Points of Discussion
Current Behavior: The existing Relation method allows applying filters to the joined table's SELECT query but does not modify the JOIN ON clause. For example(it is on #554):
Example Usage
Here is a quick example of how RelationWithOpts can be utilized:
I add this feature but actually i don't like this feature itself and the interface very much (especially, i don't like to directly face
[]schema.QueryWithArgs
). Feedback and suggestions for improving the interface and functionality are welcome. Let me know your thoughts! (If this feature is deemed unnecessary, please feel free to close this pull request without hesitation.)