Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations: parser + attribute names #161

Merged
merged 9 commits into from
Aug 13, 2023
Merged

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Jul 16, 2023

Fix uqbar-project/wollok-lsp-ide#54

  • La validación estaba de esa forma para contemplar atributos heredados.
  • La dejé solamente para atributos heredados, hice que devolviese values con un solo elemento (nombres separados por comas) para que sea traducible (interpolable).
  • Agregué otra validación para los Fields de Singletons sin inicializar (o sea, en ese caso, se marca en el atributo en vez de en el objeto).

(Viniendo la screenshot...)

Tests: uqbar-project/wollok-language#160

Falta hacer el cambio en las translations del LSP uqbar-project/wollok-lsp-ide#93

- Converted into shouldInitializeInheritedAttributes
- Adding shouldInitializeSingletonAttribute
@PalumboN PalumboN changed the title Should initialize all attributes Validations: parser + attribute names Aug 13, 2023
@PalumboN PalumboN merged commit 7dea245 into master Aug 13, 2023
2 checks passed
@PalumboN PalumboN deleted the shouldInitializeAllAttributes branch August 13, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug en vlidacion: shouldInitializeAllAttributes
2 participants