-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #292 Error poco claro cuando se omite el receptor de un mensaje #295
base: master
Are you sure you want to change the base?
Fix #292 Error poco claro cuando se omite el receptor de un mensaje #295
Conversation
…luyendo los parámetros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooow aca hay mucha magiaa 🧙♂️
alt(unamedArguments, Closure.times(1)) | ||
) | ||
obj({ | ||
receiver: succeed(new LiteralNode({ value: null })), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me hace alguito de ruido que el receiver sea un literal null, esperaria que si de verdad no tiene receiver sea un null/undefined de js. Pero bueno seguro romperia el tipado en mil lugares asi que hasta que no nos traiga problemas +1 a como esta hecho 😅
export const MALFORMED_ENTITY = 'malformedEntity' | ||
export const MALFORMED_MEMBER = 'malformedMember' | ||
export const MALFORMED_SENTENCE = 'malformedSentence' | ||
export const MALFORMED_MESSAGE_SEND = 'malformedMessageSend' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sobre lo del IDE que mencionabas en discord, para mostrar un mensaje lindo se puede tocar directamente language, que ahora tiene los diccionarios:
https://github.com/uqbar-project/wollok-language/tree/757c2561ee76f0f3f4e232bca761b5747333df85/src/resources/validationMessages
Y ahora que reviso, ninguno de estos 4 errores esta ahi. Se podria crear un issue para agregarlos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💕
No description provided.