Fix #292 Error poco claro cuando se omite el receptor de un mensaje #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luyendo los parámetros.
ivojawer
approved these changes
Oct 27, 2024
| alt(unamedArguments, Closure.times(1)) | ||
| ) | ||
| obj({ | ||
| receiver: succeed(new LiteralNode({ value: null })), |
There was a problem hiding this comment.
Me hace alguito de ruido que el receiver sea un literal null, esperaria que si de verdad no tiene receiver sea un null/undefined de js. Pero bueno seguro romperia el tipado en mil lugares asi que hasta que no nos traiga problemas +1 a como esta hecho 😅
Comment on lines
19
to
+22
| export const MALFORMED_ENTITY = 'malformedEntity' | ||
| export const MALFORMED_MEMBER = 'malformedMember' | ||
| export const MALFORMED_SENTENCE = 'malformedSentence' | ||
| export const MALFORMED_MESSAGE_SEND = 'malformedMessageSend' |
There was a problem hiding this comment.
Sobre lo del IDE que mencionabas en discord, para mostrar un mensaje lindo se puede tocar directamente language, que ahora tiene los diccionarios:
https://github.com/uqbar-project/wollok-language/tree/757c2561ee76f0f3f4e232bca761b5747333df85/src/resources/validationMessages
Y ahora que reviso, ninguno de estos 4 errores esta ahi. Se podria crear un issue para agregarlos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.