Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #297 - Cyclic const instance references #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #297 - Cyclic const instance references #299

wants to merge 1 commit into from

Conversation

PalumboN
Copy link
Contributor

@PalumboN PalumboN commented Oct 22, 2024 •
edited
Loading

@PalumboN PalumboN mentioned this pull request Oct 22, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.83%. Comparing base (6ad63ac) to head (7de4990).

Files with missing lines Patch % Lines
src/interpreter/runtimeModel.ts 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   89.81%   89.83%   +0.01%     
==========================================
  Files          28       28              
  Lines        3073     3078       +5     
  Branches      552      553       +1     
==========================================
+ Hits         2760     2765       +5     
  Misses        162      162              
  Partials      151      151

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fdodino
fdodino approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Código champagne!

src/interpreter/runtimeModel.ts
@@ -384,7 +392,7 @@ export class Evaluation {
exec(node: Expression, frame?: Frame): Execution<RuntimeObject>
exec(node: Node, frame?: Frame): Execution<undefined>
*exec(node: Node, frame?: Frame): Execution<RuntimeValue> {
if(frame) this.frameStack.push(frame)
if (frame) this.frameStack.push(frame)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jajaja, con ésto me ganaste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdodino fdodino fdodino approved these changes

@ivojawer ivojawer Awaiting requested review from ivojawer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PalumboN @fdodino