Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping trajectory #239

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Mapping trajectory #239

wants to merge 63 commits into from

Conversation

mehradans92
Copy link
Contributor

@mehradans92 mehradans92 commented Sep 1, 2020

  • Setup workflow for CG of an AA simulation using iter_from_traj based of a trajectory from GROMACS
  • Added mapped RDF.
  • Added tutorial to examples/08. Molecules CG Mapping.ipynb.

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2020

Hello @mehradans92! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-03 17:43:34 UTC

@mehradans92 mehradans92 requested a review from whitead September 1, 2020 04:30
@mehradans92 mehradans92 self-assigned this Sep 1, 2020
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add 1-2 unit tests from your notebook into test_utils.py? This will help make it clear how it should work and prevent us from breaking as development continues.

htf/utils.py Outdated Show resolved Hide resolved
htf/utils.py Outdated Show resolved Hide resolved
htf/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be errors in the jupyter notebook. Otherwise, tests and code looks good.

{
"ename": "ValueError",
"evalue": "in user code:\n\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/keras/engine/training.py:806 train_function *\n return step_function(self, iterator)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/hoomd/htf/simmodel.py:116 call *\n out = self.compute(*inputs[:self._arg_count])\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py:780 __call__ **\n result = self._call(*args, **kwds)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/def_function.py:814 _call\n results = self._stateful_fn(*args, **kwds)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2828 __call__\n graph_function, args, kwargs = self._maybe_define_function(args, kwargs)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:3171 _maybe_define_function\n *args, **kwargs)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2622 canonicalize_function_inputs\n self._flat_input_signature)\n /home/mgholiza/.conda/envs/hoomd-tf2/lib/python3.7/site-packages/tensorflow/python/eager/function.py:2713 _convert_inputs_to_signature\n format_error_message(inputs, input_signature))\n\n ValueError: Python inputs incompatible with input_signature:\n inputs: (\n Tensor(\"IteratorGetNext:0\", shape=(160, 3), dtype=float32),\n Tensor(\"IteratorGetNext:1\", shape=(160, 128, 4), dtype=float32),\n Tensor(\"IteratorGetNext:2\", shape=(3, 3), dtype=float32),\n Tensor(\"IteratorGetNext:3\", shape=(), dtype=float32))\n input_signature: (\n TensorSpec(shape=(None, 128, 4), dtype=tf.float32, name=None),\n TensorSpec(shape=(None, 4), dtype=tf.float32, name=None),\n TensorSpec(shape=(None, 3), dtype=tf.float32, name=None),\n TensorSpec(shape=(), dtype=tf.float32, name=None))\n",
"output_type": "error",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have errors in your notebook it appears.

@whitead
Copy link
Collaborator

whitead commented Nov 1, 2020

@mehradans92 is this PR done yet?

@mehradans92 mehradans92 requested a review from whitead March 10, 2021 19:22
htf/utils.py Outdated Show resolved Hide resolved
@hgandhi2411
Copy link
Collaborator

@mehradans92 There are a few empty files in your changes. Were they committed by accident?

@mehradans92
Copy link
Contributor Author

mehradans92 commented Mar 10, 2021

@hgandhi2411 No, they are not empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants