Wrapped the idiomatic "if (self = [super init])" code everywhere with…

… additional parentheses "if ((self = [super init]))" to quiet the llvm/clang static analysis that issues warning about such code.
uranpro · Mar 2, 2011 · 8e989a7 · 8e989a7
1 parent 93b15d7
commit 8e989a7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/ATMHud.m b/ATMHud.m
@@ -31,14 +31,14 @@ @implementation ATMHud
 @synthesize __view, sound, displayQueue, queuePosition;
 
 - (id)init {
-	if (self = [super init]) {
+	if ((self = [super init])) {
 		[self construct];
 	}
 	return self;
 }
 
 - (id)initWithDelegate:(id)hudDelegate {
-	if (self = [super init]) {
+	if ((self = [super init])) {
 		delegate = hudDelegate;
 		[self construct];
 	}

diff --git a/ATMHudQueueItem.m b/ATMHudQueueItem.m
@@ -15,7 +15,7 @@ @implementation ATMHudQueueItem
 @synthesize caption, image, showActivity, accessoryPosition, activityStyle;
 
 - (id)init {
-	if (self = [super init]) {
+	if ((self = [super init])) {
 		caption = @"";
 		image = nil;
 		showActivity = NO;

diff --git a/ATMHudView.m b/ATMHudView.m
@@ -41,7 +41,7 @@ - (CGPoint)sharpPoint:(CGPoint)point {
 }
 
 - (id)initWithFrame:(CGRect)frame andController:(ATMHud *)c {
-    if (self = [super initWithFrame:frame]) {
+    if ((self = [super initWithFrame:frame])) {
 		self.p = c;
 		self.backgroundColor = [UIColor clearColor];
 		self.opaque = NO;

diff --git a/ATMTextLayer.m b/ATMTextLayer.m
@@ -15,7 +15,7 @@ @implementation ATMTextLayer
 @synthesize caption;
 
 - (id)initWithLayer:(id)layer {
-	if (self = [super init]) {
+	if ((self = [super init])) {
 		caption = @"";
 	}
 	return self;

diff --git a/Classes/DemoViewController.m b/Classes/DemoViewController.m
@@ -39,7 +39,7 @@ @implementation DemoViewController
 #pragma mark -
 #pragma mark View lifecycle
 - (id)init {
-	if (self = [super init]) {
+	if ((self = [super init])) {
 		NSArray *section0 = [NSArray arrayWithObjects:@"Show with caption only", @"Show with caption and activity", @"Show with caption and image", @"Show activity only", @"Play sound on show", nil];
 		NSArray *section1 = [NSArray arrayWithObjects:@"Show and auto-hide", @"Show, update and auto-hide", @"Show progress bar", @"Show queued HUD", nil];
 		NSArray *section2 = [NSArray arrayWithObjects:@"Accessory top", @"Accessory right", @"Accessory bottom", @"Accessory left", nil];