Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch subscription list #17

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

khmMouna
Copy link
Contributor

No description provided.

@khmMouna khmMouna changed the title Add fetch subscription lis Add fetch subscription list Jul 11, 2024
Copy link
Contributor

@jyaganeh jyaganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, but lgtm overall 👍


subscriptionsPendingResult.AddResultCallback(new ResultCallback((result) =>
{
var list = new List<string>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could maybe do something like this here to avoid creating an empty list, but it's probably not a big deal either way...

subscriptionsPendingResult.AddResultCallback(new ResultCallback((result) 
{
    List<string> list = result switch
    {
        HashSet hashSet => CastHashSetToList(hashSet),
        _ => new List<string>(),
    }

    subscriptions(list);
} 

@jyaganeh jyaganeh merged commit 054a39d into main Dec 11, 2024
1 check passed
@jyaganeh jyaganeh deleted the MOBILE-4549-Add-Fetch-Subscription-lis branch December 11, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants