[MOBILE-4832] Remove MAUI dependency from Airship.Net package #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyaganeh
requested review from
crow,
rlepinski,
khmMouna,
oristanovic,
Apekka and
Ulrico972
as code owners
rlepinski
approved these changes
Dec 10, 2024
crow
approved these changes
Dec 12, 2024
jyaganeh
force-pushed
the
MOBILE-4832
branch
from
b2b2571 to
a627963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Removes MAUI as a dependency of Airship.Net, since we aren't actually exposing any MAUI UI controls from that package.
Also updated the dev readme with VSCode setup instructions, now that VS for Mac is retired.
Why are these changes necessary?
Makes our cross-platform Airship.Net package usable in 3rd-party .NET frameworks (i.e. not MAUI)
How did you verify these changes?
Ran the sample app