Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOBILE-3542] Fix doc builds and uploads; use GITHUB_OUTPUT #2

Closed
wants to merge 1 commit into from
Closed

[MOBILE-3542] Fix doc builds and uploads; use GITHUB_OUTPUT #2

wants to merge 1 commit into from

Conversation

jyaganeh
Copy link
Contributor

@jyaganeh jyaganeh commented May 3, 2023

What do these changes do?

  • Uncomments doc build and upload steps in release workflow
  • Switches to google-github-actions/auth action in place of setup-gcloud
  • Migrates ::set-output usages to $GITHUB_OUTPUT

Why are these changes necessary?

  • Docs builds/uploads were commented out because we didn't have credentials added to the repo, previously
  • set-output is deprecated and throws warnings in the actions console

@jyaganeh jyaganeh requested a review from rlepinski as a code owner May 3, 2023 21:43
@jyaganeh
Copy link
Contributor Author

Took care of this in: #8

@jyaganeh jyaganeh closed this Nov 10, 2023
@jyaganeh jyaganeh deleted the MOBILE-3542 branch November 10, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlepinski rlepinski Awaiting requested review from rlepinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jyaganeh