Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for use frameworks #7

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix for use frameworks #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae0504
fix for use frameworks
Ulrico972 Dec 6, 2024
d6f69db
update version
Ulrico972 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Airship Expo Plugin Changelog

## Version 1.3.1 - December 06, 2024
Patch version that fixes the support for Aiship Notification Service Extension when using `use_frameworks`.

## Version 1.3.0 - December 03, 2024
Minor version that adds support for Aiship Notification Service Extension and Android Custom Notification Channels.

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "airship-expo-plugin",
"version": "1.3.0",
"version": "1.3.1",
"description": "Airship Expo config plugin",
"main": "./app.plugin.js",
"scripts": {
Expand Down
2 changes: 2 additions & 0 deletions plugin/src/withAirshipIOS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ const withAirshipServiceExtensionPod: ConfigPlugin<AirshipIOSPluginProps> = (con
return withPodfile(config, async (config) => {
const airshipServiceExtensionPodfileSnippet = `
target '${NOTIFICATION_SERVICE_EXTENSION_TARGET_NAME}' do
use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks']
use_frameworks! :linkage => ENV['USE_FRAMEWORKS'].to_sym if ENV['USE_FRAMEWORKS']
pod 'AirshipServiceExtension'
end
`;
Expand Down
Loading