Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InApp Button stroke width is customizable #235

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

laura-turo
Copy link
Contributor

What do these changes do?

This PR adds the functionality to edit the stroke/border width for the InApp buttons.

Apps that want to override the stroke width in InApp Message buttons, can override the default value (2dp) by adding this to their resources (res/{values|dimens|any_name}.xml) file:

<resources>
	<integer name="ua_iam_button_stroke_width_dps">1</integer>
</resources>

Why are these changes necessary?

These changes will add flexibility to InApp Messages to get in line with the app's design.

How did you verify these changes?

Verification Screenshots:

Before After (default) After (1dp)

To override the stroke width I added <integer name="ua_iam_button_stroke_width_dps">1</integer> in
~/sample/src/main/res/values/dimens.xml

@jyaganeh
Copy link
Contributor

jyaganeh commented Dec 6, 2023

Hi @laura-turo, thanks for the PR! I'd be happy to get this merged in, but first, could you please fill out our contribution agreement ?

@laura-turo
Copy link
Contributor Author

laura-turo commented Dec 7, 2023

Hi @laura-turo, thanks for the PR! I'd be happy to get this merged in, but first, could you please fill out our contribution agreement ?

@jyaganeh Thank you! I just filled it out

@jyaganeh
Copy link
Contributor

@laura-turo I'll get this merged and start prepping a release. Thanks again!

@jyaganeh jyaganeh merged commit 7a19e19 into urbanairship:main Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants