InApp Button stroke width is customizable #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds the functionality to edit the stroke/border width for the InApp buttons.
Apps that want to override the stroke width in InApp Message buttons, can override the default value (2dp) by adding this to their resources (
res/{values|dimens|any_name}.xml
) file:Why are these changes necessary?
These changes will add flexibility to InApp Messages to get in line with the app's design.
How did you verify these changes?
Verification Screenshots:
To override the stroke width I added
<integer name="ua_iam_button_stroke_width_dps">1</integer>
in~/sample/src/main/res/values/dimens.xml