Revert "Fix button tap events from bleeding through to container"

This reverts commit c81b08f.
urbanairship · Sep 19, 2024 · 8a595cc · 8a595cc
1 parent c81b08f
commit 8a595cc
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 37 deletions.
diff --git a/Airship/AirshipCore/Source/AirshipButton.swift b/Airship/AirshipCore/Source/AirshipButton.swift
@@ -16,10 +16,10 @@ struct AirshipButton<Label> : View  where Label : View {
     let reportingMetadata: AirshipJSON?
     let description: String
     let clickBehaviors:[ButtonClickBehavior]?
-    let eventHandlers: [EventHandler]?
     let actions: ActionsPayload?
     let label: () -> Label
 
+
     var body: some View {
 
         Button(
@@ -111,28 +111,6 @@ struct AirshipButton<Label> : View  where Label : View {
         if let actions = actions {
             thomasEnvironment.runActions(actions, layoutState: layoutState)
         }
-
-        applyEventHandlers(type: .tap)
-    }
-
-    private func applyEventHandlers(type: EventHandlerType) {
-        self.eventHandlers?.forEach { eventHandler in
-            if eventHandler.type == type {
-                eventHandler.stateActions.forEach { action in
-                    switch action {
-                    case .setState(let details):
-                        viewState.updateState(
-                            key: details.key,
-                            value: details.value?.unWrap()
-                        )
-                    case .clearState:
-                        viewState.clearState()
-                    case .formValue(_):
-                        AirshipLogger.error("Unable to process form value")
-                    }
-                }
-            }
-        }
     }
 }
 

diff --git a/Airship/AirshipCore/Source/ImageButton.swift b/Airship/AirshipCore/Source/ImageButton.swift
@@ -24,7 +24,6 @@ struct ImageButton : View {
             reportingMetadata: self.model.reportingMetadata,
             description: self.model.contentDescription ?? self.model.identifier,
             clickBehaviors: self.model.clickBehaviors,
-            eventHandlers: self.model.eventHandlers,
             actions: self.model.actions
         ) {
             makeInnerButton()
@@ -33,7 +32,7 @@ struct ImageButton : View {
                 .border(self.model.border)
                 .accessible(self.model)
         }
-        .commonButton(self.model)
+        .common(self.model)
         .environment(
             \.layoutState,
              layoutState.override(

diff --git a/Airship/AirshipCore/Source/LabelButton.swift b/Airship/AirshipCore/Source/LabelButton.swift
@@ -21,7 +21,6 @@ struct LabelButton : View {
             reportingMetadata: self.model.reportingMetadata,
             description: self.model.contentDescription ?? self.model.label.text,
             clickBehaviors: self.model.clickBehaviors,
-            eventHandlers: self.model.eventHandlers,
             actions: self.model.actions
         ) {
             Label(model: self.model.label, constraints: constraints)
@@ -37,7 +36,7 @@ struct LabelButton : View {
                 .border(self.model.border)
                 .accessible(self.model)
         }
-        .commonButton(self.model)
+        .common(self.model)
         .buttonStyle(PlainButtonStyle())
         .environment(
             \.layoutState,

diff --git a/Airship/AirshipCore/Source/ViewExtensions.swift b/Airship/AirshipCore/Source/ViewExtensions.swift
@@ -27,7 +27,7 @@ public extension View {
         // broken on tvOS for now
         self
         #else
-        self.gesture(TapGesture().onEnded(action))
+        self.simultaneousGesture(TapGesture().onEnded(action))
             .accessibilityAction(.default) {
                 action()
             }
@@ -44,15 +44,6 @@ public extension View {
         }
     }
 
-    /// Common modifier for buttons so event handlers can be added separately to prevent tap issues
-    @ViewBuilder
-    internal func commonButton<Content: BaseModel>(
-        _ model: Content
-    ) -> some View {
-        self.enableBehaviors(model.enableBehaviors)
-        .visibility(model.visibility)
-    }
-
     @ViewBuilder
     internal func common<Content: BaseModel>(
         _ model: Content,