[MOBILE-3980] Add enableChannelCreation method #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulrico972
commented
Nov 9, 2023
| channelEnableChannelCreation:(RCTPromiseResolveBlock)resolve | ||
| reject:(RCTPromiseRejectBlock)reject) { | ||
| NSError *error; | ||
| [AirshipReactNative.shared channelEnableChannelCreationAndReturnError:&error]; |
There was a problem hiding this comment.
I'm not sure about this... I think it's right to add that "AndReturnError" thing but I don't fully understand how it would work lol.
Also, I'm wondering why we still have this class in objective C when we have those methods tagged with @objc in the Swift class? Any idea @rlepinski ?
There was a problem hiding this comment.
We need the obj-c for c++ bindings with the react plugin. This looks correct to me, thats standard objc bindings for errors
Ulrico972
requested review from
jyaganeh,
ilitvinenko,
Apekka,
oristanovic and
khmMouna
jyaganeh
approved these changes
Nov 10, 2023
khmMouna
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add an enableChannelCreation method and mark it as deprecated along with the isChannelCreationDelayEnabled config.
Why are these changes necessary?
To not block people that would still use the isChannelCreationDelayEnabled config.
How did you verify these changes?
Tested on iOS.
Android is working fine at APK.On my side, something with my environment is blocking for now, about CMake in the NDK...
Verification Screenshots:
Anything else a reviewer should know?