Check ExtraProperties for "airshipHmsEnabled" additionally #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Check for the "airshipHmsEnabled" flag in ExtraProperties from build.gradle on android top level additionally to check in gradle.properties.
Why are these changes necessary?
HMS requires "com.huawei.hms:push", which then requires the REQUEST_INSTALL_PACKAGES permission. This permission is considered as "high risk or sensitive permission" by Google (see https://support.google.com/googleplay/android-developer/answer/12085295?hl=en).
Making the "airshipHmsEnabled" flag available in ExtraProperties of the root projects makes it easier to control wether HMS should be used or not in react native apps which are build for HarmonyOS and Android at the same time. By that we can avoid the whole "REQUEST_INSTALL_PACKAGES" mess in Playstore easier, because changing values in build.gradle files can be done with less effort.
How did you verify these changes?
Tested in a RN app, "airshipHmsEnabled" not set in gradle.properties but in build.gradle on android top level. HMS still worked.