Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOBILE-3929] release-18.0.0 - Bump to latest SDKs #223

Merged
merged 3 commits into from
Oct 3, 2023
Merged

[MOBILE-3929] release-18.0.0 - Bump to latest SDKs #223

merged 3 commits into from
Oct 3, 2023

Conversation

jyaganeh
Copy link
Contributor

@jyaganeh jyaganeh commented Oct 2, 2023

What do these changes do?

  • Bumps to iOS 17.4.0, Android 17.3.0
  • Updated iOS Airship.cs to use notification status update constants defined on UAPush (also updated core api definitions to declare them)
  • Updated the Sample app to use the new nupkgs
  • Fixed Android tab bar so it appears at the bottom of the screen and highlights the selected item in blue
  • Commented out packing of android feature flag bindings (we'll re-enable when iOS support is also available)
  • Fixed a couple of minor warnings/suggestions in the Sample app

Why are these changes necessary?

Last bits of prep for 18.0.0 release!

How did you verify these changes?

Tested iOS and Android sample apps and checked things out in Go.

@jyaganeh jyaganeh requested a review from rlepinski as a code owner October 2, 2023 23:04
@jyaganeh jyaganeh changed the title [Release 18.0.0] Bump to latest SDKs [MOBILE-3929] release-18.0.0 - Bump to latest SDKs Oct 2, 2023
khmMouna
khmMouna approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@khmMouna khmMouna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch for notification status
Minor update to fix failed build: Need to update ios extensions in Sample app

@jyaganeh jyaganeh merged commit 21a879b into release-18.0.0 Oct 3, 2023
1 check passed
@jyaganeh jyaganeh deleted the release-18.0.0-bump-sdks branch October 3, 2023 22:56
jyaganeh added a commit that referenced this pull request Oct 4, 2023
@jyaganeh
Merge: Release 18.0.0 -> Main (#224)
5c617d9 
* [MOBILE-3862] Update bindings for SDK 17.x (#218)

* [MOBILE-3929] release-18.0.0 - Bump to latest SDKs (#223)

* Bump to iOS 17.4.0, Android 17.3.0

* Update sample

* Update extensions in sample

* Update nuspec airship dep versions

* Bump SampleApp.Android to target API 33 and add post notification permission to manifest

* Update changelog; add migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khmMouna khmMouna khmMouna approved these changes

@rlepinski rlepinski rlepinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyaganeh @rlepinski @khmMouna