Fix uuid serialization

Vincit#39
urbestteam · Oct 8, 2018 · 5da25f3 · 5da25f3
1 parent 0335a25
commit 5da25f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/venia/core.cljc b/src/venia/core.cljc
@@ -2,7 +2,8 @@
   (:require [venia.spec :as spec]
             [clojure.string :as str])
   #?(:clj
-     (:import (clojure.lang IPersistentMap Keyword IPersistentCollection))))
+     (:import (clojure.lang IPersistentMap Keyword IPersistentCollection)
+              (java.util UUID))))
 
 (defprotocol ArgumentFormatter
   "Protocol responsible for query arguments' formatting to string.
@@ -30,6 +31,8 @@
           (arg->str [arg] "null")
           String
           (arg->str [arg] (str "\"" arg "\""))
+          UUID
+          (arg->str [arg] (str "\"" arg "\""))
           IPersistentMap
           (arg->str [arg] (str "{" (arguments->str arg) "}"))
           IPersistentCollection
@@ -44,6 +47,8 @@
            (arg->str [arg] "null")
            string
            (arg->str [arg] (str "\"" arg "\""))
+           UUID
+           (arg->str [arg] (str "\"" arg "\""))
            PersistentArrayMap
            (arg->str [arg] (str "{" (arguments->str arg) "}"))
            PersistentHashMap

diff --git a/test/venia/core_test.cljc b/test/venia/core_test.cljc
@@ -98,6 +98,12 @@
           query-str "{employee(id:1,active:true){name,address,friends(id:1){name,email}}}"]
       (is (= query-str (v/graphql-query data)))))
 
+  (testing "Should serialize uuids to strings"
+    (let [data {:venia/queries [[:employee {:id #uuid "db60501e-26c0-43d0-a4d8-21bd401acf6b"}
+                                 [:name]]]}
+          query-str "{employee(id:\"db60501e-26c0-43d0-a4d8-21bd401acf6b\"){name}}"]
+      (is (= query-str (v/graphql-query data)))))
+
   (testing "Should create a valid graphql string using params on fields."
     (let [data {:venia/queries [[:employee [[:name {:isEmpty false}] :address [:friends [:name [:email {:isValid true}]]]]]]}
           query-str "{employee{name(isEmpty:false),address,friends{name,email(isValid:true)}}}"]