Merge next/kelvin/411 to develop #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The +fitz jet erronously excludes all uppercase letters but the last one from aura compatibility check. In +fitz aura compatibility check, only the last uppercase letter is considered a bit-width annotation.
Companion PR to [#6639 in Arvo](urbit/urbit#6639)
This PR ports urbit/urbit#5676, correcting an integer overflow in the +jam jet (leading to a mismatch on large-atom input). Fixes urbit/urbit#5674. Releasing this fix is blocked on #346. DO NOT MERGE.
This has fallen way behind -- should fix urbit/urbit#6860
...and if not, keep trying until we go over the whole buffer (Note: the parsde port is wrong)
WIP branch (on top on ted/ping; will be merged there). Uses urbit/urbit#6836 for the %arvo side. - [x] Send/Receive STUN request/response, handled in %arvo by stopping the %ping app. - [x] Check DNS resolution -- currently we send STUNs in fakeship mode - (check changing hosts.txt) - [ ] refactor _stun_czar, _ames_czar, - make a generic _dns_czar(imp_y) that gets called every ~m5 for our sponsoring galaxy, and every time an %ames packet is sent to another galaxy - [x] refactor _ames_czar/stun_gone - [x] Use XOR-MAPPED-ADDRESS to send the sponsee's IP - [x] Better STUN (re)sends, regarding timers (e.g. number of tries per attempt... etc) - "send requests at times 0 ms, 500 ms, 1500 ms, 3500 ms, 7500 ms, 15500 ms, and 31500 ms. If the client has not received a response after 39500 ms", stop, inject %fail, (re)resolve DNS, and restart STUN. - [x] Callback error handling - if a response failes, ignore—sender will try again - if a request fails, resend it - if the DNS resolution fails, stop everyting and restart - if the response doesn't arrive in ~s39, inject %fail, stop everything and restart - [ ] DNS Error handling - [x] Failure to resolve DNS (first time) -- have a global ~s25 timer? - [x] Change in sponsor's IP -- resolve DNS on failure to hear a response? - [x] ~~exponentially backoff~~resolve DNS every 5 minutes - [x] Better STUN response check - [x] Add sponsee's IP to MAPPED-ADDRESS attribute field - [x] cache ip address - [x] (re)enable %ping app after failure to hear STUN response, if we eventually hear one - [ ] Test plan: see last point in urbit/urbit#6836 (comment)
CI on urbit/urbit next/kelvin/411 was broken, presumably because of this.
We were previously reusing the %139 declarations for %138. But urbit/urbit#6859 requires that we remove jets in %138, and #439 required that we remove a jet in prior versions (temporarily handled by removing it from all versions in #526). Additionally, this PR removes obsolete and unused jets and hooks for `+hike` and `|ap`.
Also refactors fetching the protocol version twice.
DNS galaxy resolution needs to be treated differently when dealing with STUN packets to our sponsor and when this is meant to be for another galaxy, as part of sending an ames packet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.