Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vere: adds %quic loom measurement, support it and |mass in conn #740

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Oct 28, 2024

Resolves #

@joemfb joemfb marked this pull request as ready for review November 6, 2024 21:02
@joemfb joemfb requested a review from a team as a code owner November 6, 2024 21:02
@joemfb
Copy link
Member Author

joemfb commented Nov 6, 2024

These changes should be ready to go. I've cleaned up crash issues with the async-request lifecycle, and refactored some of the interfaces from #675.

To work around the absence of -W on macos nc, I've used socat -t300 -,ignoreeof UNIX-CONNECT:$SHIP/.urb/conn.sock.

The build issues here are a little strange. I think that dependencies are not properly declared between packages in the zig build system. I had local build issues adding new motes and using them in serf.c -- I ended up manually removing the zig cache.

@joemfb
Copy link
Member Author

joemfb commented Nov 6, 2024

At some point, conn.c should be decoupled from newt.c so that these socket shenanigans are no longer necessary. Errors / EOF on the read side of a conn connection should not (necessarily) tear down the entire connection.

@pkova pkova merged commit 4974074 into develop Nov 14, 2024
2 checks passed
@pkova pkova deleted the jb/quic branch November 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants