Кулешова Ирина #53
Open
Кулешова Ирина #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройдено тестов 9 из 9 |
bazhenova
reviewed
Nov 11, 2016
| off: function (event, context) { | ||
| console.info(event, context); | ||
| var eventsToOff = Object.keys(this._events).filter( | ||
| function (key) { |
There was a problem hiding this comment.
и еще эту строку можно к предыдущей приписать, так обычно пишут
bazhenova
reviewed
Nov 11, 2016
| function (key) { | ||
| return key === event || | ||
| (key.length > event.length && | ||
| key.substr(0, event.length + 1) === event + '.'); |
There was a problem hiding this comment.
вроде из условий
(key.length > event.length && key.substr(0, event.length + 1) === event + '.')достаточно написать последнее
bazhenova
reviewed
Nov 11, 2016
| key.substr(0, event.length + 1) === event + '.'); | ||
| } | ||
| ); | ||
| for (var i = 0; i < eventsToOff.length; i++) { |
bazhenova
reviewed
Nov 11, 2016
| emit: function (event) { | ||
| console.info(event); | ||
| var events = getAllEvents(event).reverse(); | ||
| for (var i = 0; i < events.length; i++) { |
There was a problem hiding this comment.
и тут вроде forEach хорошо впишется, тогда не придется создавать новую переменную строчкой ниже
bazhenova
reviewed
Nov 11, 2016
|
|
||
|
|
||
| function getAllEvents(event) { | ||
| var splitted = event.split('.'); |
There was a problem hiding this comment.
Название не отражает, что лежит в переменной
bazhenova
reviewed
Nov 11, 2016
| */ | ||
| emit: function (event) { | ||
| console.info(event); | ||
| var events = getAllEvents(event).reverse(); |
There was a problem hiding this comment.
если ты сплитишь event, а потом реверсишь, то почему бы сразу не пойти с конца?
bazhenova
reviewed
Nov 11, 2016
| ); | ||
| for (var i = 0; i < eventsToOff.length; i++) { | ||
| this._events[eventsToOff[i]] = this._events[eventsToOff[i]].filter( | ||
| function (item) { |
|
🍅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.