-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Петрова Ксения #12
base: master
Are you sure you want to change the base?
Петрова Ксения #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не хватает тестов для получения твитов и в formatDate не хватает проверки на плохие аргументы, а так все хорошо
function formatDate(date) { | ||
// Напишите код форматирования даты в этом месте | ||
date = new Date(date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лучше входные данные не менять
function formatDate(date) { | ||
// Напишите код форматирования даты в этом месте | ||
date = new Date(date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а если из api некорректное что-то придет? null, например
} | ||
|
||
function getTweets () { | ||
return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
за промисы 👍
No description provided.