Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Петрова Ксения #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ksenipetrova
Copy link

No description provided.

Copy link
Collaborator

@zmenka zmenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не хватает тестов для получения твитов и в formatDate не хватает проверки на плохие аргументы, а так все хорошо

function formatDate(date) {
// Напишите код форматирования даты в этом месте
date = new Date(date);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше входные данные не менять

function formatDate(date) {
// Напишите код форматирования даты в этом месте
date = new Date(date);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а если из api некорректное что-то придет? null, например

}

function getTweets () {
return new Promise((resolve, reject) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

за промисы 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants