Гомзяков Андрей #130
Open
Гомзяков Андрей #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍏 Пройден линтинг и базовые тесты |
| @@ -0,0 +1,28 @@ | |||
| # Задача «Ацссорти» | |||
There was a problem hiding this comment.
зачем же копировать в папку еще одну было(
| } | ||
| div:nth-child(5) { | ||
| background: #ffff66; | ||
| } |
There was a problem hiding this comment.
обойдись без nth-child, посмотри чем верстка отличается
| } | ||
| .c7 { | ||
| background: #ffff66 !important; | ||
| } |
There was a problem hiding this comment.
не используй important, когда можно обойтись без него
| <style> | ||
| input:checked~input { | ||
| outline: 1px solid #ff6698; | ||
| } |
| opacity: 0.5; | ||
| } | ||
| div:hover { | ||
| opacity: 1.5; |
| } | ||
| div:hover { | ||
| opacity: 1.5; | ||
| } |
There was a problem hiding this comment.
неправильно работает, другие квадраты должны становиться тусклее
|
|
||
| <main class="global-results"> | ||
| <style> | ||
| input:checked~div { |
There was a problem hiding this comment.
лучше ставить пробелы input:checked ~ div
|
|
||
| <main class="global-results"> | ||
| <style> | ||
| [href]~[href] { |
There was a problem hiding this comment.
именно vk должно быть синего (как в задании а не дефолтного)
а все ссылки на яндекс - красного
| <main class="global-results"> | ||
| <style> | ||
|
|
||
| a[target="_blank"] { |
There was a problem hiding this comment.
_blank - не значит что внешние относительно my-site.ru
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотреть решение