Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Малышкин Александр #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

libgtso
Copy link

@libgtso libgtso commented Oct 17, 2018

@honest-hrundel honest-hrundel changed the title edit this staff Малышкин Александр Oct 17, 2018
@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

background: #98ff66;
}

aside

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно объединить с div

color: #6698ff;
}

article > a:nth-child(n + 2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Работает, но можно еще проверять на наличие yandex.ru в ссылке

opacity: .3;
}

img[alt^='css']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно было сделать одним селектором, использовав :not

opacity: .5;
}

article:hover > a[href='https://ya.ru']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Работает не совсем правильно. Надо, чтобы hover реагировал при наведении на каждую ссылку отдельно, а сейчас реагирует на обе сразу

border: 3px solid #ff6698;
}

article > input:nth-child(2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь хотелось, чтобы цвет выбирался в зависимости от валидности емейла в инпуте, а не просто по первому и второму инпуту

background: #ffb366;
}

div:nth-child(5),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно еще посмотреть на верстку внимательнее и найти отличие желтых блоков от оранжевых

opacity: .5;
}

div:hover

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По ховеру остальные квадраты еще должны становиться более прозрачными

@@ -12,7 +12,10 @@ <h1 class="global-heading">&nbsp;</h1>

<main class="global-results">
<style>
/* your styles here */
.red-gt2:nth-child(n + 3) > div

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не соответствует условию:
css 2000 2018-10-23 13-52-46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants