Плаксин Иван #26
Open
Плаксин Иван #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍅 Не пройден линтинг или базовые тесты |
|
🍅 Не пройден линтинг или базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
|
🍏 Пройден линтинг и базовые тесты |
chrighter
requested changes
Nov 27, 2018
| <a class="notifications_icon" href="#"></a> | ||
| <div class="settings"> | ||
| <input type="checkbox" class="input__settings-button" id="settings-button"> | ||
| <label class="settings-button" for="settings-button">Настройка</label> |
| <title>Задача «Морда»</title> | ||
| <link href="index.css" rel="stylesheet"> | ||
| </head> | ||
| <body> |
| <div class="header grid__column_1 grid__row_1"> | ||
| <div class="current-city"> | ||
| <a href="#" class="current-city__link"> | ||
| <svg class="current-city__navigation-arrow"> |
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Давай оптимизировать svg с помощью svgo https://www.npmjs.com/package/svgo
| <input type="checkbox" class="settings__tv-program" id="tv-program"> | ||
| <input type="checkbox" class="settings__best-jokes" id="best-jokes"> | ||
|
|
||
| <div class="grid"> |
| двухместный самолёт Cessna упал на католическое кладбище. | ||
| Спасатели уже обнаружили 750 тел, поиски продолжаются. | ||
| </span><br> | ||
| <label for="joke1" class="next-joke_button text_link_hover">Показать еще</label> |
| <label for="joke3" class="next-joke_button text_link_hover">Показать еще</label> | ||
| </div> | ||
| </div> | ||
| </div> |
| <div class="search grid-row-5 grid__column_1-2"> | ||
| <a href="#" class="search-logo"></a> | ||
| <input type="text" class="search-bar" autofocus> | ||
| <a href="#" class="search-bar_button">Найти</a> |
| <title>Задача «Морда»</title> | ||
| <link href="index.css" rel="stylesheet"> | ||
| </head> | ||
| <body> |
| <a class="notifications_icon" href="#"></a> | ||
| <div class="settings"> | ||
| <input type="checkbox" class="input__settings-button" id="settings-button"> | ||
| <label class="settings-button" for="settings-button">Настройка</label> |
There was a problem hiding this comment.
Давай еще как в макете отмечать, какие виджеты добавил/удалил пользователь
chrighter
requested changes
Nov 27, 2018
| <input type="checkbox" class="settings__best-jokes" id="best-jokes"> | ||
|
|
||
| <div class="grid"> | ||
| <div class="header grid__column_1 grid__row_1"> |
There was a problem hiding this comment.
Давай не будем называть классы css-свойствами
chrighter
requested changes
Nov 29, 2018
| двухместный самолёт Cessna упал на католическое кладбище. | ||
| Спасатели уже обнаружили 750 тел, поиски продолжаются. | ||
| </span><br> | ||
| <label for="joke1" class="next-joke_button text_link_hover">Показать еще</label> |
There was a problem hiding this comment.
Иногда при появлении очередного анекдота контент прыгает
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотреть решение