Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about FP ground points in distant sectors #60

Open
a120471 opened this issue Oct 31, 2024 · 0 comments
Open

Question about FP ground points in distant sectors #60

a120471 opened this issue Oct 31, 2024 · 0 comments

Comments

@a120471
Copy link

a120471 commented Oct 31, 2024

I try out the patchwork++ recently, and thanks for your efforts on this work. It's very efficiency and user-friendly. :)

However, I encountered some FP ground points. After diving into the implementation code, I find one particular line somewhat puzzling:
https://github.com/url-kaist/patchwork-plusplus/blob/master/cpp/patchworkpp/src/patchworkpp.cpp#L268

From my understanding, when using the default parameter num_rings_of_interest = 4, all distant sector ground points seem to be consistently included in the final ground. Which means if any distant sectors missed the ground points, there is a big chance that some FP points will be included.

Is this the intended behavior? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant