WIP todo

urlaubsverwaltung · May 17, 2023 · decdbf2 · decdbf2
1 parent e149bac
commit decdbf2
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/main/java/de/focusshift/zeiterfassung/report/ReportControllerHelper.java b/src/main/java/de/focusshift/zeiterfassung/report/ReportControllerHelper.java
@@ -119,11 +119,21 @@ ReportOvertimesDto reportOvertimesDto(ReportWeek reportWeek) {
         // john   | 1 | 2 | 2 | 3 | 4 | 4 | 4   <- `ReportOvertimeDto ( personName, overtimes )`
         // jane   |   |   | 2 | 3 | 4 | 4 | 4   <- `ReportOvertimeDto ( personName, overtimes )`
 
+        // TODO users without entries this week, but present in the reportWeek
+        // each day of the week has `plannedWorkingHoursByUser` and `accumulatedOvertimeToDateByUser` which should both contain the same users
+        // jack   |   |   |   |   |   |   |     <- `ReportOvertimeDto ( personName, overtimes )`
+
+        // vielleicht am schluss über plannedWorkingHours personen iterieren und fehlende den `users` hinzufügen.
+        // welche zahl kommt dann in einen block?
+        //    geplant bzw muss gearbeitet werden an dem tag: Map<UserLocalId, PlannedWorkingHours> plannedWorkingHoursByUser
+        //    bisher angesammelte überstunden bis zum tag startOfBusiness: Map<UserLocalId, OvertimeDuration> accumulatedOvertimeToDateByUser
+
         // build up `users` peace by peace. one person could have the first working day in the middle of the week (jane).
         final Set<User> users = new HashSet<>();
 
         // {john} -> [1, 2, 2, 3, 4, 4, 4]
         // {jane} -> [empty, empty, 2, 3, 4, 4, 4]
+        // {jack} -> [empty, empty, empty, empty, empty, empty, empty] (has no entries this week)
         final Map<User, List<Optional<OvertimeDuration>>> overtimeDurationsByUser = new HashMap<>();
 
         // used to initiate the persons list of overtimes.