-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ruff formatter #24
Conversation
From the docs:
I suppose I just disable it for that one line |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 13 13
Lines 1548 1548
=======================================
Hits 1518 1518
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ah you've found it already. |
@@ -84,6 +84,8 @@ ignore = [ | |||
"N818", # Exception names should end in "Error", requires API change | |||
"S101", # Use of assert, should be changed in the future | |||
"ANN204", # Do not use return typing on __init__, __new__ and __call__ methods | |||
"E111", # Recommended to be disabled when using the ruff formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, never had any issues with those rules before but I guess I have never used a non-standard indent.
@sgaisser There is an issue formatting a certain line below the 120 line width with ruff.. any ideas? maybe some conflict with a lint?