Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add 2FA disable endpoint #263

Merged
merged 1 commit into from
Feb 16, 2024
Merged

✨ Add 2FA disable endpoint #263

merged 1 commit into from
Feb 16, 2024

Conversation

usatie
Copy link
Owner

@usatie usatie commented Feb 16, 2024

DELETE /auth/2fa/disable
とりあえずbackendで2faを非有効化するためのエンドポイントを作成しました。

Copy link
Contributor

coderabbitai bot commented Feb 16, 2024

Walkthrough

The recent updates introduce the ability to disable two-factor authentication (2FA) for a user. A new endpoint has been added to the authentication controller, along with a corresponding service method to perform the action. Additionally, end-to-end tests have been updated to cover the new functionality, including test utility enhancements to facilitate these tests. These changes streamline the process of toggling 2FA for enhanced security management.

Changes

File(s) Change Summary
backend/src/auth/auth.controller.ts Added endpoint to disable 2FA; updated JwtGuardWithout2FA to include JwtAuthGuard.
backend/src/auth/auth.service.ts Added disableTwoFactorAuthentication method to disable 2FA for a user.
backend/test/auth.e2e-spec.ts, backend/test/utils/app.ts Added test cases and utility method for disabling and re-enabling 2FA.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@usatie usatie merged commit 2837e6a into main Feb 16, 2024
4 checks passed
@usatie usatie deleted the feat/backend/disable-2fa branch February 16, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant