Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Prevent sending or receiving friend requests between users who have blocked each other #294

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

lim396
Copy link
Collaborator

@lim396 lim396 commented Mar 4, 2024

  • フレンドリクエストのテストにブロック関連のテストを追加しました。
  • 自分がblockしているユーザーにフレンドリクエストを送れない、受け取れないように修正しました。
  • 自分をblockしているユーザーのフレンドリクエストを受け取れないように修正しました。

Copy link
Contributor

coderabbitai bot commented Mar 4, 2024

Walkthrough

The recent update introduces a mechanism to ensure users cannot interact in ways that would violate blocking relationships within a social platform. A new method, expectNotBlocking, has been added to the FriendRequestService to check for any blocking relationships before proceeding with friend-related operations. Additionally, the test suite has been expanded to cover scenarios involving blocked users, enhancing the robustness of user interactions and ensuring that blocked states are respected across various functionalities.

Changes

Files Change Summaries
.../friend-request.service.ts Added expectNotBlocking method to prevent operations between users in blocking relationships.
.../user.e2e-spec.ts Enhanced test coverage for blocking scenarios, including handling of friend requests and blocked users.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@lim396 lim396 changed the title [backend] prevent sending or receiving friend requests between users who have blocked each other [backend] Prevent sending or receiving friend requests between users who have blocked each other Mar 4, 2024
@lim396 lim396 merged commit f606b66 into main Mar 4, 2024
4 checks passed
@lim396 lim396 deleted the fix/backend/friend-request branch March 4, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant