Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document contribution guide and related activities #392

Merged
merged 25 commits into from
Oct 17, 2023
Merged

Document contribution guide and related activities #392

merged 25 commits into from
Oct 17, 2023

Conversation

TylerHendrickson
Copy link
Member

Description

This PR adds a CONTRIBUTORS.md file, updates the README with useful information for developers, and updates the provided Taskfile.yml.

Testing

Refer to the README's new Quick Reference section and ensure the listed commands work as-described.

Manual tests for Reviewer

  • Added steps to test feature/functionality manually

Checklist

  • Provided ticket and description
  • Provided testing information
  • Provided adequate test coverage for all new code
  • Added PR reviewers

@TylerHendrickson TylerHendrickson requested a review from a team as a code owner October 5, 2023 01:21
@TylerHendrickson TylerHendrickson self-assigned this Oct 5, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation github Repository automation and configuration labels Oct 5, 2023
@TylerHendrickson TylerHendrickson mentioned this pull request Oct 5, 2023
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Terraform Summary

Step Result
🖌 Terraform Format & Style ✅
⚙️ Terraform Initialization ✅
🤖 Terraform Validation ✅
📖 Terraform Plan ✅

Output

Validation Output 
Success! The configuration is valid.
Plan Output 
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.DownloadFFISSpreadsheet.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "c6aa45f99d6dfdad046c90af88003f05-3" -> (known after apply)
      ~ id                     = "faf4133149ac61f650724e9919b0fe50.zip" -> (known after apply)
      ~ key                    = "faf4133149ac61f650724e9919b0fe50.zip" -> "7b5ea50fd8401e42e3ef2812c8c951b2.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "9XpKS.RLoRaGEEE36t9Hgfyurj_x0jGA" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.DownloadFFISSpreadsheet.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-DownloadFFISSpreadsheet"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadFFISSpreadsheet:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadFFISSpreadsheet:27/invocations" -> (known after apply)
      ~ s3_key                         = "faf4133149ac61f650724e9919b0fe50.zip" -> "7b5ea50fd8401e42e3ef2812c8c951b2.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                      = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadffisspreadsheet" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadffisspreadsheet"
              ~ "DD_VERSION"                   = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.DownloadFFISSpreadsheet.module.lambda_function.aws_lambda_permission.current_version_triggers["SQSQueueNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "SQSQueueNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (4 unchanged attributes hidden)
    }

  # module.DownloadGrantsGovDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "aa5f1b5d6ee2e88086f44220df724235-3" -> (known after apply)
      ~ id                     = "5ddfdd27fc59d457a0a2c41a950bfd56.zip" -> (known after apply)
      ~ key                    = "5ddfdd27fc59d457a0a2c41a950bfd56.zip" -> "311ff8966c44b38afe729541067751a5.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "MOTTBepRL_GpFdZe.XFq4DErMTjGKRom" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.DownloadGrantsGovDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-DownloadGrantsGovDB"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadGrantsGovDB:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-DownloadGrantsGovDB:27/invocations" -> (known after apply)
      ~ s3_key                         = "5ddfdd27fc59d457a0a2c41a950bfd56.zip" -> "311ff8966c44b38afe729541067751a5.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                        = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadgrantsgovdb" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:downloadgrantsgovdb"
              ~ "DD_VERSION"                     = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (12 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.DownloadGrantsGovDB.module.lambda_function.aws_lambda_permission.current_version_triggers["Schedule"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "Schedule" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.EnqueueFFISDownload.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "7913ba4c9b0973e2919b52d2bbb96a09-3" -> (known after apply)
      ~ id                     = "8acfe3b24378e8ebeb70110e8282f16c.zip" -> (known after apply)
      ~ key                    = "8acfe3b24378e8ebeb70110e8282f16c.zip" -> "7aceaf4acaa3bb632d85a97891962d37.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "6897A7r4cExUSpJBBbM6Fy7JEZx3wLj5" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.EnqueueFFISDownload.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-EnqueueFFISDownload"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-EnqueueFFISDownload:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-EnqueueFFISDownload:27/invocations" -> (known after apply)
      ~ s3_key                         = "8acfe3b24378e8ebeb70110e8282f16c.zip" -> "7aceaf4acaa3bb632d85a97891962d37.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                      = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:enqueueffisdownload" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:enqueueffisdownload"
              ~ "DD_VERSION"                   = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.EnqueueFFISDownload.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.ExtractGrantsGovDBToXML.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "f31edd23c204971d91055825232451b6-3" -> (known after apply)
      ~ id                     = "1d916c78b7981828c97e2c0876e556af.zip" -> (known after apply)
      ~ key                    = "1d916c78b7981828c97e2c0876e556af.zip" -> "fea2f22066e59ab08bbd37951a4df89b.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "cF49gQR4XHfQfC_oa6PstWDJGgS2LW7H" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.ExtractGrantsGovDBToXML.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-ExtractGrantsGovDBToXML"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ExtractGrantsGovDBToXML:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ExtractGrantsGovDBToXML:27/invocations" -> (known after apply)
      ~ s3_key                         = "1d916c78b7981828c97e2c0876e556af.zip" -> "fea2f22066e59ab08bbd37951a4df89b.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                      = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:extractgrantsgovdbtoxml" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:extractgrantsgovdbtoxml"
              ~ "DD_VERSION"                   = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.ExtractGrantsGovDBToXML.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PersistFFISData.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "661d1d63a24b35cf678239085ad4855d-3" -> (known after apply)
      ~ id                     = "78b6b8d9815149423f88f913d68c65c6.zip" -> (known after apply)
      ~ key                    = "78b6b8d9815149423f88f913d68c65c6.zip" -> "2e3952e96626a94fad6616793d53d6bf.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "5AIQNVmHbCj.hXKEiGMp3prmygbMfH2K" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PersistFFISData.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-PersistFFISData"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistFFISData:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistFFISData:27/invocations" -> (known after apply)
      ~ s3_key                         = "78b6b8d9815149423f88f913d68c65c6.zip" -> "2e3952e96626a94fad6616793d53d6bf.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                       = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistffisdata" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistffisdata"
              ~ "DD_VERSION"                    = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.PersistFFISData.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PersistGrantsGovXMLDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "d89850daf7cd671dae0586a595ebc656-3" -> (known after apply)
      ~ id                     = "1d58d46f6a50884f257f30d55abd3dc6.zip" -> (known after apply)
      ~ key                    = "1d58d46f6a50884f257f30d55abd3dc6.zip" -> "f78f0582bebb2c1acb17c1c2ad9993a2.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "q3OoHtfmzyAXvzZ9EniySZFl7mJxkX5k" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PersistGrantsGovXMLDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-PersistGrantsGovXMLDB"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistGrantsGovXMLDB:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PersistGrantsGovXMLDB:27/invocations" -> (known after apply)
      ~ s3_key                         = "1d58d46f6a50884f257f30d55abd3dc6.zip" -> "f78f0582bebb2c1acb17c1c2ad9993a2.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                       = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistgrantsgovxmldb" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:persistgrantsgovxmldb"
              ~ "DD_VERSION"                    = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.PersistGrantsGovXMLDB.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PublishGrantEvents.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "e9bff5aee3382b9bd5f48f7efa2bed78-3" -> (known after apply)
      ~ id                     = "6dc4455b51c1b95e60a784e1ea51e49c.zip" -> (known after apply)
      ~ key                    = "6dc4455b51c1b95e60a784e1ea51e49c.zip" -> "c19df77ec49324d074b4e83af2f6876b.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "ThRngre5uyw7dcuDDzlrl26GoBorE_yN" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.PublishGrantEvents.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-PublishGrantEvents"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PublishGrantEvents:28" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-PublishGrantEvents:28/invocations" -> (known after apply)
      ~ s3_key                         = "6dc4455b51c1b95e60a784e1ea51e49c.zip" -> "c19df77ec49324d074b4e83af2f6876b.zip"
        tags                           = {}
      ~ version                        = "28" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                      = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:publishgrantevents" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:publishgrantevents"
              ~ "DD_VERSION"                   = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (11 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.PublishGrantEvents.module.lambda_function.aws_lambda_permission.current_version_triggers["dynamodb"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "dynamodb" -> (known after apply)
      ~ qualifier           = "28" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.ReceiveFFISEmail.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "592fd9e7d35789b38f5d9115ecaae8b3-3" -> (known after apply)
      ~ id                     = "92e23db52dd9170f064cf463de497e32.zip" -> (known after apply)
      ~ key                    = "92e23db52dd9170f064cf463de497e32.zip" -> "8411b095cb9d87f8f63c5587538f4961.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "DzhCbVMGbEoBUGV_SOzR2hOOR5VT89Ed" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.ReceiveFFISEmail.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-ReceiveFFISEmail"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ReceiveFFISEmail:26" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-ReceiveFFISEmail:26/invocations" -> (known after apply)
      ~ s3_key                         = "92e23db52dd9170f064cf463de497e32.zip" -> "8411b095cb9d87f8f63c5587538f4961.zip"
        tags                           = {}
      ~ version                        = "26" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                        = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:receiveffisemail" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:receiveffisemail"
              ~ "DD_VERSION"                     = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (12 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.ReceiveFFISEmail.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "26" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.SplitFFISSpreadsheet.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "2c9d9587e6d234d48448e160178b2810-3" -> (known after apply)
      ~ id                     = "05002741bc8344e806def1f250b5ccb6.zip" -> (known after apply)
      ~ key                    = "05002741bc8344e806def1f250b5ccb6.zip" -> "c53c01997f02bdfd2b1a2c339f2e8c51.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "lx9Sw.TTJSUW8Wa8BnbjWk4T0z9RIGBv" -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.SplitFFISSpreadsheet.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-SplitFFISSpreadsheet"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitFFISSpreadsheet:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitFFISSpreadsheet:27/invocations" -> (known after apply)
      ~ s3_key                         = "05002741bc8344e806def1f250b5ccb6.zip" -> "c53c01997f02bdfd2b1a2c339f2e8c51.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                          = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitffisspreadsheet" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitffisspreadsheet"
              ~ "DD_VERSION"                       = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (14 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.SplitFFISSpreadsheet.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.SplitGrantsGovXMLDB.module.lambda_artifact.aws_s3_object.lambda_function must be replaced
-/+ resource "aws_s3_object" "lambda_function" {
      ~ bucket_key_enabled     = false -> (known after apply)
      ~ content_type           = "binary/octet-stream" -> (known after apply)
      ~ etag                   = "260b3e42bf1f21a49199966dc007609d-3" -> (known after apply)
      ~ id                     = "6aa802f14e52bdf9b855d085064c92d5.zip" -> (known after apply)
      ~ key                    = "6aa802f14e52bdf9b855d085064c92d5.zip" -> "ba95ce32d5fd1ac98d78c661a09a4600.zip" # forces replacement
+       kms_key_id             = (known after apply)
-       metadata               = {} -> null
      ~ storage_class          = "STANDARD" -> (known after apply)
-       tags                   = {} -> null
      ~ version_id             = "3mw6LZMKd_SbnyQUMFafd5s_k60OYwx." -> (known after apply)
        # (5 unchanged attributes hidden)
    }

  # module.SplitGrantsGovXMLDB.module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "grants_ingest-SplitGrantsGovXMLDB"
      ~ last_modified                  = "2023-10-13T00:34:46.000+0000" -> (known after apply)
      ~ qualified_arn                  = "arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitGrantsGovXMLDB:27" -> (known after apply)
      ~ qualified_invoke_arn           = "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:357150818708:function:grants_ingest-SplitGrantsGovXMLDB:27/invocations" -> (known after apply)
      ~ s3_key                         = "6aa802f14e52bdf9b855d085064c92d5.zip" -> "ba95ce32d5fd1ac98d78c661a09a4600.zip"
        tags                           = {}
      ~ version                        = "27" -> (known after apply)
        # (19 unchanged attributes hidden)

      ~ environment {
          ~ variables = {
              ~ "DD_TAGS"                          = "git.commit.sha:3bd5cdc01af1d503fb46a72501bdcc78c665f67a,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitgrantsgovxmldb" -> "git.commit.sha:95e792ba366f9f23188698e458f734a2c25ce7e9,git.repository_url:github.com/usdigitalresponse/grants-ingest,handlername:splitgrantsgovxmldb"
              ~ "DD_VERSION"                       = "3bd5cdc01af1d503fb46a72501bdcc78c665f67a" -> "95e792ba366f9f23188698e458f734a2c25ce7e9"
                # (14 unchanged elements hidden)
            }
        }

        # (3 unchanged blocks hidden)
    }

  # module.SplitGrantsGovXMLDB.module.lambda_function.aws_lambda_permission.current_version_triggers["S3BucketNotification"] must be replaced
-/+ resource "aws_lambda_permission" "current_version_triggers" {
      ~ id                  = "S3BucketNotification" -> (known after apply)
      ~ qualifier           = "27" # forces replacement -> (known after apply) # forces replacement
+       statement_id_prefix = (known after apply)
        # (5 unchanged attributes hidden)
    }

Plan: 20 to add, 10 to change, 20 to destroy.

Pusher: @TylerHendrickson, Action: pull_request_target, Workflow: Continuous Integration

@TylerHendrickson TylerHendrickson enabled auto-merge (squash) October 5, 2023 01:47
CelesteChang
CelesteChang approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@CelesteChang CelesteChang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some suggestions relative to CONTRIBUTING.md. It's a good practice to ventilate prose, or write one sentence per line, because the raw text is clearer for reviewing. The other good thing is that the file will look the same when previewed.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
TylerHendrickson and others added 12 commits October 17, 2023 12:39
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
b38a9f6 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
73d1935 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
51b74c6 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
200608a 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
b64fbfc 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
7333419 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
d06438f 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
2670e2a 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
b6687db 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
bd84759 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
aec7bb5 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson @CelesteChang
Update CONTRIBUTING.md
dd3d0db 
Co-authored-by: CelesteChang <[email protected]>
@TylerHendrickson
Copy link
Member Author

Looks great! Just some suggestions relative to CONTRIBUTING.md. It's a good practice to ventilate prose, or write one sentence per line, because the raw text is clearer for reviewing. The other good thing is that the file will look the same when previewed.

Thanks for the review and excellent feedback, @CelesteChang! I applied all of your suggestions; the call-out for ventilated prose is especially useful – something I wasn't previously familiar with but makes a lot of sense. I've always been focused on line-length for markdown changes, but after looking at the results, I'd agree this is much easier to read 😄

Thanks again!

@TylerHendrickson TylerHendrickson merged commit d4588a8 into main Oct 17, 2023
18 checks passed
@TylerHendrickson TylerHendrickson deleted the docs/contributor-guide-and-activities branch October 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelesteChang CelesteChang CelesteChang approved these changes

@as1729 as1729 Awaiting requested review from as1729

Assignees

@TylerHendrickson TylerHendrickson

Labels
documentation Improvements or additions to documentation github Repository automation and configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerHendrickson @CelesteChang